On Thu, 9 Dec 2021 at 20:10, Joel Holdsworth <jholdsworth@xxxxxxxxxx> wrote: > > The git-p4.py script currently implements code-paths for both Python 2 and > 3. > > Python 2 was discontinued in 2020, and there is no longer any officially > supported interpreter. Further development of git-p4.py will require > would-be developers to test their changes with all supported dialects of > the language. However, if there is no longer any supported runtime > environment available, this places an unreasonable burden on the Git > project to maintain support for an obselete dialect of the language. > > This patch-set removes all Python 2-specific code-paths, and then > applies some simplifications to the code which are available given > Python 3's improve delineation between bytes and strings. I might as well take this opportunity to say that I've stopped needing to worry about git-p4! Hurrah! I'm finding that the unit tests no longer pass with this change. I'm not exactly sure why. Luke > > Joel Holdsworth (6): > git-p4: Always pass cmd arguments to subprocess as a python lists > git-p4: Don't print shell commands as python lists > git-p4: Removed support for Python 2 > git-p4: Decode byte strings before printing > git-p4: Eliminate decode_stream and encode_stream > git-p4: Resolve RCS keywords in binary > > git-p4.py | 319 +++++++++++++++++++++--------------------------------- > 1 file changed, 123 insertions(+), 196 deletions(-) > > -- > 2.33.0 >
