Re: [PATCH 00/19] tests: fix broken &&-chains & abort loops on error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 09, 2021 at 02:17:32PM -0500, Eric Sunshine wrote:

> > I have to admit to starting to skim once I got to the last four
> > patches, since they were a bit longer and all the same type of change.
> 
> Understandable. Those bulk-change patches tend to be mind-numbing to
> review, though `git diff --color-words` helps out somewhat (at least
> by making it easier to skim the changes).

I likewise think I may have phased in and out of consciousness on those
last four.

> > You did an excellent job of explaining the changes and presented them
> > in a logical fashion.  The few things I thought I caught, you've
> > already answered were already correct.  I do think making the second
> > commit message be a bit clearer about the importance of the ordering
> > would be helpful.  Anyway:
> >
> > Reviewed-by: Elijah Newren <newren@xxxxxxxxx>
> 
> Thanks. I'll wait a couple days and resend with a clarified commit
> message for the second patch unless, perhaps, Junio would accept a
> resend of just that patch so I don't have to spam the list again.

These looked good to me. I left a few comments, but nothing that I think
would trigger a re-roll.

-Peff



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux