On Thu, Dec 9, 2021 at 12:03 PM Elijah Newren <newren@xxxxxxxxx> wrote: > On Wed, Dec 8, 2021 at 11:39 PM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > > Although the new chainlint implementation has been complete for several > > months, I'm still working out how to organize its patch series. In the > > meantime, _this_ patch series fixes problems discovered by the new > > linter due to its improved coverage and extra semantic knowledge about > > Git tests. As much as possible, I resisted the temptation to make > > ancillary cleanups (including indentation fixes) to tests even when such > > cleanups would be obvious improvements. Avoiding such unrelated cleanups > > should make the long patches in this series, which touch a lot of tests, > > easier to review (--color-words helps a lot here). > > I have to admit to starting to skim once I got to the last four > patches, since they were a bit longer and all the same type of change. Understandable. Those bulk-change patches tend to be mind-numbing to review, though `git diff --color-words` helps out somewhat (at least by making it easier to skim the changes). > You did an excellent job of explaining the changes and presented them > in a logical fashion. The few things I thought I caught, you've > already answered were already correct. I do think making the second > commit message be a bit clearer about the importance of the ordering > would be helpful. Anyway: > > Reviewed-by: Elijah Newren <newren@xxxxxxxxx> Thanks. I'll wait a couple days and resend with a clarified commit message for the second patch unless, perhaps, Junio would accept a resend of just that patch so I don't have to spam the list again.
