Han-Wen Nienhuys <hanwen@xxxxxxxxxx> writes: > On Wed, Dec 8, 2021 at 5:13 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: >> >> error: ISO C99 doesn't support unnamed structs/unions [-Werror=pedantic] >> > >> > Hmm. It's interesting that the regular DEVELOPER=1 doesn't catch this. >> > It's because we don't specify -std there, and newer gcc defaults to >> > gnu17 (unnamed unions appeared in c11, I think). I wonder if it would be >> > helpful to teach config.mak.dev to pass -std=c99. >> >> FWIW, I use -std=gnu99 as our Makefile suggests. > > I understand that the default build should be lenient rather than > strict for portability reasons. However, it would be good if the CI > was strict with this. Yeah, I agree with the above, and was a bit surprised that I found the issue via my local build after it came from GGG.
