This series was targeted to 'next'. This addresses some complaints from Coverity that Peff reported. CI on GGG shows a segfault on windows (https://github.com/git/git/runs/4446635428?check_suite_focus=true), which I can't make sense of. Any hints would be greatly appreciated. Han-Wen Nienhuys (10): reftable: fix OOB stack write in print functions reftable: fix resource leak in error path reftable: fix resource leak blocksource.c reftable: check reftable_stack_auto_compact() return value reftable: ignore remove() return value in stack_test.c reftable: fix resource warning reftable: fix NULL derefs in error paths reftable: order unittests by complexity reftable: drop stray printf in readwrite_test reftable: make reftable_record a tagged union reftable/block.c | 29 ++++-- reftable/block_test.c | 22 ++--- reftable/blocksource.c | 6 +- reftable/generic.c | 35 ++++---- reftable/iter.c | 4 +- reftable/merged.c | 37 ++++---- reftable/pq.c | 3 +- reftable/pq_test.c | 31 +++---- reftable/reader.c | 108 ++++++++++++----------- reftable/readwrite_test.c | 1 - reftable/record.c | 180 +++++++++++++++----------------------- reftable/record.h | 45 ++++------ reftable/record_test.c | 162 +++++++++++++++++----------------- reftable/stack.c | 15 ++-- reftable/stack_test.c | 3 +- reftable/writer.c | 46 +++++----- t/helper/test-reftable.c | 9 +- 17 files changed, 360 insertions(+), 376 deletions(-) base-commit: a8338297339b1ab064e799c15c4fc56c122ef967 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1152%2Fhanwen%2Freftable-coverity-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1152/hanwen/reftable-coverity-v1 Pull-Request: https://github.com/git/git/pull/1152 -- gitgitgadget
