On Mon, Nov 29, 2021 at 06:16:54PM -0800, Junio C Hamano wrote: > * pw/xdiff-classify-record-in-histogram (2021-11-18) 3 commits > - xdiff: simplify comparison > - xdiff: avoid unnecessary memory allocations > - diff histogram: intern strings > > "diff --histogram" optimization. > > Will merge to 'next'. This being merged to 'next' tickled my -Wunused-parameter topic, so there were a few more opportunities for cleanup. Definitely not urgent, but I think worth doing. Prepared on top of the topic branch. [1/3]: xdiff: drop CMP_ENV macro from xhistogram [2/3]: xdiff: drop xpparam_t parameter from histogram cmp_recs() [3/3]: xdiff: drop unused flags parameter from recs_match xdiff/xdiffi.c | 18 +++++++++--------- xdiff/xhistogram.c | 8 ++------ 2 files changed, 11 insertions(+), 15 deletions(-) -Peff