Re: [PATCH 9/9] Implement git commit as a builtin command.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2007-09-17 at 19:56 -0400, Jeff King wrote:
> On Mon, Sep 17, 2007 at 06:58:01PM -0400, Kristian Høgsberg wrote:
> 
> > > > -	builtin-runstatus.o \
> > > 
> > > Better keep it; some people's scripts could depend on it.
> > 
> > Seriously?  Why don't we remove it and see if somebody yells?  It's more
> > of an implementation detail than most other git commands; if you need
> > status output in your script why wouldn't you just run git status?
> 
> As the author of builtin-runstatus, I had always intended that it was a
> temporary part of the transition to a C git-commit, and would go away
> then. But I see in the interim somebody documented it.  It should
> perhaps have been called git-status--helper, and the documentation
> should have read "DO NOT USE THIS."

That's what I suspected, thanks for clearing that up.  It definitely
feels more like a step towards a built-in commit than a useful command
on it's own.  It plugs right into this work, so as such, it's been a
success.

Kristian


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux