Re: [PATCH 7/9] Add strbuf_read_path().

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 7/9] Add strbuf_read_path().
From: Johannes Schindelin <Johannes.Schindelin@xxxxxx>
Date: Thu, 6 Sep 2007 17:40:02 +0100 (BST)
Cc: git@xxxxxxxxxxxxxxx
In-reply-to: <11890382262161-git-send-email-krh@xxxxxxxxxx>

Hi,

On Wed, 5 Sep 2007, Kristian Høgsberg wrote:

> +extern int strbuf_read_path(struct strbuf *sb, const char *path);

May I suggest renaming this to "strbuf_read_file()"?  I kind of expected a 
function which reads in the absolute path of a file, judging by the 
name...

Ciao,
Dscho

References:
- [PATCH 1/9] Enable wt-status output to a given FILE pointer.
  - From: Kristian Høgsberg
- [PATCH 2/9] Enable wt-status to run against non-standard index file.
  - From: Kristian Høgsberg
- [PATCH 3/9] Add strbuf_printf() to do formatted printing to a strbuf.
  - From: Kristian Høgsberg
- [PATCH 4/9] Introduce entry point for launching add--interactive.
  - From: Kristian Høgsberg
- [PATCH 5/9] Introduce strbuf_read_fd().
  - From: Kristian Høgsberg
- [PATCH 6/9] Rewrite launch_editor, create_tag and stripspace to use strbufs.
  - From: Kristian Høgsberg
- [PATCH 7/9] Add strbuf_read_path().
  - From: Kristian Høgsberg

Prev by Date: [PATCH] git-svn: remove --first-parent, add --upstream
Next by Date: [PATCH 5/3] archive: rename attribute specfile to export-subst
Previous by thread: Re: [PATCH 9/9] Implement git commit as a builtin command.
Next by thread: Re: [PATCH 6/9] Rewrite launch_editor, create_tag and stripspace to use strbufs.
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]

Powered by Linux