Why are the no-op messages for git-push and git-pull (i.e. when remote
and local are identical) so different, while describing something very
similar? IMO the messages should be either identical or very similar.
git-pull results in “Already up to date.”, while git-push results
in “Everything up-to-date”.
Note the difference in the usage of “Already” vs. “Everything”,
dashes vs. spcaes, and a period vs. no period. While I understand that
these aren’t saying the same thing and therefore some difference is
warranted, might I suggest that this difference be limited to the words
“Already” and “Everything”?
I have attached a patch—I hope this is a correct way of doing this.
It should be considered that other messages reading “Already up to
date.” seem to use a translation system, it might be better to use
that system here, too. Unfortunately, I don’t know how to do that
(currently). At any rate, this patch could serve as a temporary
“fix”.
From 01d2df17c0055120f5e16f105effdeeb5d288566 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Anselm=20Sch=C3=BCler?= <mail@xxxxxxxxxxxxxxxxxx>
Date: Mon, 29 Nov 2021 00:42:37 +0100
Subject: [PATCH] =?UTF-8?q?Change=20=E2=80=9CEverything=20up-to-date?=
=?UTF-8?q?=E2=80=9D=20to=20=E2=80=9CAlready=20up=20to=20date=E2=80=9D=20f?=
=?UTF-8?q?or=20more=20consistency?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Signed-off-by: Anselm Schüler <mail@xxxxxxxxxxxxxxxxxx>
---
builtin/send-pack.c | 2 +-
transport.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/send-pack.c b/builtin/send-pack.c
index 69c432ef1a..ad90fb0370 100644
--- a/builtin/send-pack.c
+++ b/builtin/send-pack.c
@@ -338,7 +338,7 @@ int cmd_send_pack(int argc, const char **argv, const char *prefix)
}
if (!ret && !transport_refs_pushed(remote_refs))
- fprintf(stderr, "Everything up-to-date\n");
+ fprintf(stderr, "Already up to date.\n");
return ret;
}
diff --git a/transport.c b/transport.c
index e4f1decae2..1e224794cc 100644
--- a/transport.c
+++ b/transport.c
@@ -1401,7 +1401,7 @@ int transport_push(struct repository *r,
if (porcelain && !push_ret)
puts("Done");
else if (!quiet && !ret && !transport_refs_pushed(remote_refs))
- fprintf(stderr, "Everything up-to-date\n");
+ fprintf(stderr, "Already up to date.\n");
return ret;
}
--
2.33.1
