Hi Junio, On Mon, 22 Nov 2021, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > >> But if we were to do so, perhaps we'd want something like what I > >> gave at https://lore.kernel.org/git/xmqqy25lwa86.fsf@gitster.g/ in > >> its place to avoid confusing people. > > > > That sounds like a good course of action to me. > > > > Please note that the MSVC-related adjustment of the `FLEX_ARRAY` block is > > still needed, I think. > > The "something like what I gave ... to avoid confusing people" patch > is following up on the direction to drop the patch with -std=gnu99 > change. IIRC, your MSVC adjustment was to tweak that patch we were > discussing of dropping, so even if it is still needed, it won't be > part of what I was doing. I thought we were only dropping the `--std=gnu99` part, not the change to the `git-compat-util.h` header file, nor the patch to the CMake configuration for MS Visual C. Ciao, Dscho
