On Mon, Nov 15, 2021 at 04:06:45PM +0100, Patrick Steinhardt wrote: > Sorry, but I'm currently completely loaded with work and thus didn't > find the capacity to have a deeper look yet and will probably not find > the time for a few more days. So the earliest I can have a look at this > is probably beginning next week. > > With that in mind, I'm happy to have this change reverted for now, as it > is... Thanks for chiming in (and again, sorry for bringing this up so late in the cycle). > > > We probably should revert this step as it can affect correctness in > > > a big way, but I wonder if the other steps in the same series, or > > > other topic that came later, rely on it. > > > > I looked them over, and I think this is pretty independent (with the > > exception of the refactoring of the no_walk/unsorted flags, but > > obviously that had to come first). > > .. completely independent of the other patches in this series and can be > reverted on its own. Only question is whether we also want to revert the > patch introducing this option in the first place given that it would end > up without a user afterwards. It looks like Junio queued a revert of the whole patch in a7df4f52af (Revert "connected: do not sort input revisions", 2021-11-11), which is on "master". So I think we should have a clean slate to look at this in the next cycle. -Peff
