On Wed, 10 Nov 2021 at 12:28, Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > > Hi Junio, > > On Tue, 9 Nov 2021, Junio C Hamano wrote: > > > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > > > > I fear that it is a bit late in the -rc cycle to try to get this into the > > > official v2.34.0. Adam, since you are the maintainer of the Cygwin git > > > package, would you mind incorporating this patch into Cygwin's version of > > > Git? > > > > I do not mind taking a Cygwin-only #ifdef block in compat/ like we > > see below from folks who have stake in Cygwin, and who are clearly > > leading Cygwin users on the list, like Ramsay and Adam are, even > > after I tag -rc2. > > Thank you for your encouragement, I contributed it here: > https://lore.kernel.org/git/pull.1074.git.1636542550889.gitgitgadget@xxxxxxxxx > > > I cannot give the change any better test than they can, and it is > > their platform to improve, or break by accident while trying to do > > so. > > Right. I tested this as well as I could, via the `--stress` option, and am > fairly confident that it is correct. Since the patch touches only > `simply-ipc` code, the only test that could possibly affected is t0052, > and it passes with `--stress` over here (when it failed without the > patch). > > Ciao, > Dscho > > P.S.: in case you wondered, no, I did not run the entire test suite. With > the performance characteristics of the POSIX emulation provided by the > Cygwin runtime, this would simply take too long. It's not the first time I > wish our test suite was more efficient, across _all_ supported platforms. I have just run the complete test suite on rc2, both with and without this patch, and I can confirm it resolves this problem and doesn't cause any other new test failures. But yes, the (lack of) speed of running the Git test suite on Cygwin is one of the reasons I run the tests on high-spec Azure VMs rather than my own systems. Unfortunately the Cygwin compatibility layer plus the overheads of NTFS mean things are unlikely to get significantly quicker any time soon, and between WSL and Git for Windows, I expect interest in improving Cygwin's performance is going to continue to wane.
