On Wed, Nov 10, 2021 at 01:15:52AM -0800, Carlo Arenas wrote: > On Wed, Nov 10, 2021 at 12:22 AM Jeff King <peff@xxxxxxxx> wrote: > > > > On Wed, Nov 10, 2021 at 12:11:12AM -0800, Carlo Arenas wrote: > > > > > On Tue, Nov 9, 2021 at 10:02 PM Jeff King <peff@xxxxxxxx> wrote: > > > > > > > - we're not really testing the desired behavior, just looking for a > > > > known-problem. The segfault may get fixed but we'd still have other > > > > bugs. > > > > > > This openssh bug was fixed in 8.8 per the release notes; indeed the > > > fix[1] (which was misapplied but fixed next commit) looks familiar and > > > it is just a straight up crasher, hence unlikely to cause other > > > issues. > > > > Ah, thanks for digging. I agree that this is a small isolated bug, so > > the prereq check I showed would be a good test for it. > > > > IMHO it's worth doing. It looks like 8.7 is the only affected openssh > > version, but it is likely to cause confusion right when we release. > > It was discussed[1] before, and I think the plan was to at least > mention the brokenness with 8.7 in the release notes, but guess I > dropped the ball by not raising it earlier. Ah, thanks. I looked in the archive, but assumed any mention would have been more recent (not realizing that Debian's packaging was simply lagging the upstream releases by quite a bit). -Peff