On Tue, Nov 9, 2021 at 10:02 PM Jeff King <peff@xxxxxxxx> wrote: > - we're not really testing the desired behavior, just looking for a > known-problem. The segfault may get fixed but we'd still have other > bugs. This openssh bug was fixed in 8.8 per the release notes; indeed the fix[1] (which was misapplied but fixed next commit) looks familiar and it is just a straight up crasher, hence unlikely to cause other issues. Agree with you though that with both git and openssh getting changes released for this feature there is a probability that there might be misbehaving combinations that are not appropriately tested, but your patch is a good step in the right direction. Carlo [1] https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/ssh-keygen.c.diff?r1=1.435&r2=1.436&f=h
