On Wed, Nov 03, 2021 at 11:01:16AM -0500, Steven Penny wrote: > On Wed, Nov 3, 2021 at 6:10 AM Jeff King wrote: > > Hmm, that's the right output, I think. Even though it's wrapped in > > single-quotes I think that's just how run_command shows it. > > Why does this have no quotes: > > run-command.c:666 trace: run_command: git-remote-https origin > https://github.com/89z/googleplay > > and this have quotes: > > run-command.c:666 trace: run_command: 'git credential-store get' > > If youre saying that both commands ran unquoted, then I believe you. But > hopefully you'll agree that even if nothing is wrong with the code that runs the > commands, that the output is confusing at best, and misleading at worst. It's because internally, the "git credential-store get" command is assembled as a single string passed to the shell, whereas remote-https is run directly via exec/spawn. I agree the output is confusing. That may give us a clue as to what's going wrong, though. I.e., there could be some issue with the shell on your system. > Hopefully you won't fault me for just wanting something that works, so I am just > going to use my AskPass program [2] that I wrote in response to this situation. > Ironically, "git push" is actually faster now than it was with Netrc, so I guess > that's a win. Thanks for the responses. Nope, that's definitely your right if you don't want to spend time digging further. But as I can't reproduce here, it may mean the problem goes unsolved. We do have tests for credential-store in our test suite, so if it were broken for everybody, I expect we'd have noticed. If it is specific to your system somehow, then you working around it is as good as a solution. :) -Peff
