Hi Eli, On Thu, 4 Nov 2021, Johannes Schindelin wrote: > On Tue, 26 Oct 2021, Eli Schwartz wrote: > > > On 10/26/21 8:06 AM, Đoàn Trần Công Danh wrote: > > > Other than the question pointed out by Eric, > > > > > > with DEVELOPER=1, -Werror=declaration-after-statement > > > We'll need this change squashed in: > > > > > > Thanks for the advice. In v1 of this patchset I attempted to do a > > developer build but failed due to preexisting errors: > > > > > > CC run-command.o > > run-command.c: In function ‘async_die_is_recursing’: > > run-command.c:1102:9: error: ‘pthread_setspecific’ expecting 1 byte in a > > region of size 0 [-Werror=stringop-overread] > > 1102 | pthread_setspecific(async_die_counter, (void *)1); > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > In file included from /usr/include/openssl/crypto.h:415, > > from /usr/include/openssl/comp.h:16, > > from /usr/include/openssl/ssl.h:17, > > from git-compat-util.h:309, > > from cache.h:4, > > from run-command.c:1: > > /usr/include/pthread.h:1308:12: note: in a call to function > > ‘pthread_setspecific’ declared with attribute ‘access (none, 2)’ > > 1308 | extern int pthread_setspecific (pthread_key_t __key, > > | ^~~~~~~~~~~~~~~~~~~ > > cc1: all warnings being treated as errors > > > > > > > > My system has a custom compiled glibc from git roughly around the 2.34 > > release (a similar environment could be obtained by using Fedora rawhide > > I guess), and this commit looks mighty suspicious: > > https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=a1561c3bbe8e72c6e44280d1eb5e529d2da4ecd0 > > > > For this reason, I did not bother to try testing v2 under a developer > > build, leading to my overlooking this issue. ;) > > It seems that this issue now hit an official version. As I explained in > https://lore.kernel.org/git/nycvar.QRO.7.76.6.2111040007170.56@xxxxxxxxxxxxxxxxx/T/#u, > my colleague Victoria Dye will send a fix for this later. FYI here is the patch: https://lore.kernel.org/git/pull.1072.v2.git.1635998463474.gitgitgadget@xxxxxxxxx/ Ciao, Johannes
