On Mon, Nov 01, 2021 at 12:06:20AM +0530, Kaartic Sivaraam wrote: > > This commit has an extra unused parameter in the helper function. I > > think we'd want the patch below on top. > > > > Sorry for the oversight and thanks for catching it (again)! > > This reminded me to check my config.mak and enable DEVELOPER=1 > which I seem to have turned off for some reason. I did notice > we explicitly add -Wno-unused-parameter to DEVELOPER_CFLAGS (likely > with good reason). The rest of the flags should be helpful though :) Yes, there are hundreds of false positives for -Wunused-parameter. I have a series annotating all of them (which is indeed how I found the problem fixed here), but I haven't quite gotten around to cleaning them all up. (Plus I've been a little afraid to flood the list with them). -Peff
