On 26/10/21 10:55 am, Jeff King wrote:
On Mon, Oct 25, 2021 at 08:48:04PM -0700, Junio C Hamano wrote:
* ks/submodule-add-message-fix (2021-10-23) 1 commit
(merged to 'next' on 2021-10-25 at 377e759528)
+ submodule--helper: fix incorrect newlines in an error message
Message regression fix.
Will merge to 'master'.
This commit has an extra unused parameter in the helper function. I
think we'd want the patch below on top.
Sorry for the oversight and thanks for catching it (again)!
This reminded me to check my config.mak and enable DEVELOPER=1
which I seem to have turned off for some reason. I did notice
we explicitly add -Wno-unused-parameter to DEVELOPER_CFLAGS (likely
with good reason). The rest of the flags should be helpful though :)
--
Sivaraam