On Fri, Oct 29, 2021 at 02:58:48PM -0700, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > However, according to the unsetenv() manpage: > > > > Prior to glibc 2.2.2, unsetenv() was prototyped as returning void; > > more recent glibc versions follow the POSIX.1-compliant prototype > > shown in the SYNOPSIS. > > > > So it is POSIX to return an int, but that gives us at least one platform > > where unsetenv() returns void (or used to). glibc 2.2.2 is 2001-era, so > > that may be old enough that we don't care. But it makes me wonder if > > other older or obscure platforms will run into this. > > Ahh, OK. Well, we will hear from them soon enough. It is not like > this is anything urgent. Yeah, I am OK proceeding along those lines, and seeing if anybody screams (though perhaps dropping xunsetenv() for -rc0 makes sense in the interim). -Peff
