On Fri, Oct 29, 2021 at 02:27:05PM -0700, Carlo Marcelo Arenas Belón wrote: > Platforms that are using the git compatibility layer for unsetenv > use void as a return value for unsetenv(), so any function that checks > for a return value will fail to build. Good catch. > Remove the unused wrapper function. I don't mind removing this if nobody is using it, but doesn't your first paragraph argue that our definition of gitunsetenv() is just wrong? I.e., it should return an int, even if it is always "0"? Or is it a portability question? I.e., are there platforms where unsetenv() also returns void, in which case we must make sure nobody ever looks at its return value (and xunsetenv() is therefore a wrong direction)? -Peff
