Eli Schwartz <eschwartz@xxxxxxxxxxxxx> writes:
> On 10/29/21 4:11 PM, Junio C Hamano wrote:
>> Eli Schwartz <eschwartz@xxxxxxxxxxxxx> writes:
>>
>>> + struct {
>>> + char *name;
>>> + enum { OPT_STRING } type;
>>> + } option[] = {
>>> + { "exclude", OPT_STRING },
>>> + { "match", OPT_STRING },
>>> + };
>>
>> I floated OPT_<TYPE> in my earlier illustration as "something like
>> this", not "literally use these tokens". We have CPP macros of the
>> same name in parse-options.h API---we may not see troubles from the
>> name clashes today, but let's not leave it to chances.
>>
>> Perhaps call it like DESCRBE_ARG_STRING or something that ensures
>> uniqueness like that?
>
>
> Ah. That alternative seems a bit long though. :( Without breaking enum
> type into one per line, it will quickly overflow line lengths... though
> maybe it should be one per line anyway?
Yes, these things should be one item per line; a patch that adds or
removes one would become easier to read.
>
> Will try to put some thought into naming.
