On 10/27/2021 4:22 PM, Ævar Arnfjörð Bjarmason wrote: > > On Wed, Oct 27 2021, Derrick Stolee wrote: >> It still seems like we're better off letting the client request a >> filter and have the server present URIs that the client can use, >> and the server can choose to ignore the filter or provide URIs that >> are specific to that filter.[...] > > I've tested this a bit now and think there's no way to create such a > bundle currently. I.e. try: > > git clone --filter=blob:none --single-branch --no-tags https://github.com/git/git.git > cd git > git config --unset remote.origin.partialclonefilter > git config --unset remote.origin.promisor > > You'll get: > > $ GIT_TRACE_PACKET=1 git bundle create --version=3 master.bdl master > Enumerating objects: 306784, done. > Counting objects: 100% (306784/306784), done. > Compressing objects: 100% (69265/69265), done. > fatal: unable to read c85385dc03228450cb7fb6d306252038a91b47e6 > error: pack-objects died > > If you didn't do that config munging we'd create the pack, but it would > be inflated with the blobs (after going back and getting them from the > server). > > So aside from any questions of how you'd hypothetically communicate your > desire to get such bundle from the server, I don't think it could serve > one up. > > So I think this is moot until the bundle format itself could support > it. I'll need to "git bundle [verify|unbundle]" whatever I get on the > other end. Thank you for demonstrating that bundles don't currently work with filters. This would need to be remedied, but can be done independently. For now, let's just make sure that there is a paved path for extending whatever is decided here to work with filters in the future. As for the overall design, I have some thoughts that I'm going to break out into a new message responding to your cover letter. Thanks, -Stolee
