Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: >> Not a problem introduced by this function, but if you look at this >> change with "git show -W", we'd notice that the function name on the >> hunk header looks strange. I think we should add a blank line >> before the beginning of the function. > > I think this is a bug in -W, after all if without it we we show the > function context line, but with it we advance further, then that means > that -W didn't find the correct function boundary. That's a chicken-and-egg argument, and I do not think it is a bug in "-W" nor the funcname regular expression pattern we use. We expect a blank line there and the pattern reflects that expectation, so not having an expected blank line is what causes this problem. In any case, we should add a blank linke before the beginning of the function, and of course that is obviously outside the scope of these patches.
