On Fri, Oct 22, 2021 at 09:36:04PM +0200, Ævar Arnfjörð Bjarmason wrote: > This version of this series drops the Makefile-powered version of the > cmdlist in favor of making the shellscript much faster, mostly with > suggestions from Jeff King. I'd be happy with the version that you suggest here, since at least the net-effect is that generate-commandlist.sh is faster than before without much additional complexity. That said, I did find the structure of these patches somewhat confusing. There is a lot of refactoring of get_categories() and related functions, and those patches were a little tricky to read for me. I wonder how much could be cleaned up by placing "generate-cmdlist.sh: stop sorting category lines" earlier in the series, getting rid of the caller. It's too bad that the penultimate patch slowed things down a bit, but I think that things are so fast now that much more discussion in this area is really just splitting hairs. It would be interesting to hear from somebody on Windows whether or not the speed-up there was worth it (otherwise dropping that patch might make sense). Anyway, I think we've all spent a lot of time discussing a rather straightforward set of patches ;-). So this version looks good to me. Thanks, Taylor
