Taylor Blau <me@xxxxxxxxxxxx> writes: > test_bitmap_walk() is used to implement `git rev-list --test-bitmap`, > which compares the result of the on-disk bitmaps with ones generated > on-the-fly during a revision walk. > > In fa95666a40 (pack-bitmap.c: harden 'test_bitmap_walk()' to check type > bitmaps, 2021-08-24), we hardened those tests to also check the four > special type-level bitmaps, but never freed those bitmaps. We should > have, since each required an allocation when we EWAH-decompressed them. > > Free those, plugging that leak, and also free the base (the scratch-pad > bitmap), too. > > Signed-off-by: Taylor Blau <me@xxxxxxxxxxxx> > --- I've looked at the patches up to this point. The ones I did not comment (including this one ;-) looked perfect, and all of them (including the ones I did comment) were cleanly described to easily read the reasoning behind these changes, which I highly appreciated. Especially if I did not quite agree with the reasoning, it helped me clarify my thought where I found it not agreeable. Thanks.
