Here is a topic that Ævar got me interested when he mentioned that t5319 is leaky[1]. This is the result of trying to get t5319 to pass when compiling with SANITIZE=leak. About 50% of the fixes are in the MIDX code, another 40% are in the pack-bitmap code, and the remaining 10% are sort of random. I tried to separate these out based on their respective areas. The last 10% are all from leaking memory in the rev_info structure, which I punted on for now by just UNLEAK()-ing it. That's all done in the last patch. If we choose to take that last patch, then t5319 passes even under SANITIZE=leak builds. But it's a little gross, so I'm happy to leave it out if others would prefer. This is based on tb/fix-midx-rename-while-mapped, with a back-merge of js/windows-ci-path-fix in order to appease CI. It also contains a little bit of overlap with a patch[2] from Ævar in another series, which he and I discovered independently. I cherry-picked his patch, since I haven't seen much action on that series lately. [1]: https://lore.kernel.org/git/87wnmph73b.fsf@xxxxxxxxxxxxxxxxxxx/ [2]: https://lore.kernel.org/git/patch-v3-08.10-e0a3510dd88-20211013T222329Z-avarab@xxxxxxxxx/ Taylor Blau (10): midx.c: clean up chunkfile after reading the MIDX midx.c: don't leak MIDX from verify_midx_file t/helper/test-read-midx.c: free MIDX within read_midx_file() builtin/pack-objects.c: don't leak memory via arguments builtin/repack.c: avoid leaking child arguments builtin/multi-pack-index.c: don't leak concatenated options pack-bitmap.c: avoid leaking via midx_bitmap_filename() pack-bitmap.c: don't leak type-level bitmaps pack-bitmap.c: more aggressively free in free_bitmap_index() t5319: UNLEAK() the remaining leaks Ævar Arnfjörð Bjarmason (1): pack-bitmap-write.c: don't return without stop_progress() builtin/log.c | 1 + builtin/multi-pack-index.c | 4 ++++ builtin/pack-objects.c | 12 ++++++++---- builtin/repack.c | 35 ++++++++++++++++++++++++----------- builtin/rev-list.c | 2 ++ midx.c | 7 +++++-- pack-bitmap-write.c | 8 +++++--- pack-bitmap.c | 18 ++++++++++++++++-- t/helper/test-read-midx.c | 3 ++- t/t5319-multi-pack-index.sh | 1 + 10 files changed, 68 insertions(+), 23 deletions(-) -- 2.33.0.96.g73915697e6
