On Wed, Oct 20, 2021 at 02:32:21PM -0700, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > Yeah, I faced something similar with 7c5045fc18 (ref-filter: apply > > fallback refname sort only after all user sorts, 2020-05-03). I suspect > > you could use the same keys as those tests, though I am OK if we simply > > leave it as a quietly-fixed bug. > > Ah, I guess I can cheat and add a new test after these. > > If --no-sort weren't taking effect, the expected outcome would be > the asme as the previous step this copied from, but with --no-sort > clearing the sort keys, we sort by taggerdate and then tiebreak with > the refname, and taggeremail does not get into the picture (other > than being repeated at the end of the refname). Yeah, I think what you have here makes sense. It's too bad we can't run it on the "before" state to double-check that we are triggering the old breakage, but there is simply no "--no-sort" at all before your patch (which is good, because it would have been broken ;) ). -Peff
