On Wed, Oct 20, 2021 at 11:40 PM Taylor Blau <me@xxxxxxxxxxxx> wrote: > From: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> > > Fix a bug that's been here since 7cc8f971085 (pack-objects: implement > bitmap writing, 2013-12-21), we did not call stop_progress() if we > reached the early exit in this function. > > We could call stop_progress() before we return, but better yet is to > defer calling start_progress() until we need it. > > This will matter in a subsequent commit where we BUG(...) out if this > happens, and matters now e.g. because we don't have a corresponding > "region_end" for the progress trace2 event. Nit: There is no subsequent commit in this series which "BUGS out", so this comment is confusing. > Suggested-by: SZEDER Gábor <szeder.dev@xxxxxxxxx> > Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> > Signed-off-by: Taylor Blau <me@xxxxxxxxxxxx>
