Re: [PATCH 1/2] git-commit: Disallow unchanged tree in non-merge mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Thu, 13 Sep 2007, Junio C Hamano wrote:
>
> "Dmitry V. Levin" <ldv@xxxxxxxxxxxx> writes: 
> > Yes, the check looks almost redundant if run_status is enabled, but
> > - the bug fixed by commit v1.5.3.1-15-g4fb5fd5 was found due to
> >   this check;
> > - the check itself is very cheap compared to run_status;
> 
> That is worrisome.  Maybe run_status is too expensive because it
> is doing something stupid?  IOW, can you make run_status cheaper
> for you?

It would be interesting to hear what the situation is that makes 
run_status be too expensive. Doing a "git status" on the kernel tree 
currently takes something like 0.3 seconds for me when the directory and 
stat information cached - and while it's obviously going to be a *lot* 
slower if there's IO involved, that IO is basically required for doing the 
up-to-date check anyway.

So maybe somebody already described the situation that was slow already, 
but if so, can we get a repeat of that description?

		Linus
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux