"Shawn O. Pearce" <spearce@xxxxxxxxxxx> writes: > Junio C Hamano <gitster@xxxxxxxxx> wrote: >> "Shawn O. Pearce" <spearce@xxxxxxxxxxx> writes: >> >> > But I have to also wonder, aside from the sick amend case I just >> > talked about, how does one get to this part of git-commit.sh with >> > nothing to commit? >> >> Yeah, I also have to wonder. Existing run_status call should >> have taken care of things. > > By the next patch; the one that introduces the --fast flag and lets > the user bypass the run_status call. Which then makes this new check > the only safety valve the user has to prevent them from making an > empty commit and not realize they have forgotten to add files. But isn't that quite a bogus reason? Why does this piece of code need to spend extra cycles if already checked with run_status? I do not see anything that disables this redundant check from the normal codepath in patch [2/2]. Or am I looking at a wrong patch? - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
