Re: [PATCH] git-send-email.perl: Add angle brackets to In-Reply-To if necessary

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Uwe Kleine-König  <ukleinek@xxxxxxxxxxxxxxxxxxxxxxxxxx> writes:

> [I wonder why Pierre didn't get a Cc: ...]

Thusly added him back...

> David Kastrup wrote:
>> 
>> Signed-off-by: David Kastrup <dak@xxxxxxx>
>> ---
>> I had previously already sent this patch.  It is somewhat more robust
>> than your version against off-by-one cut&paste errors.  But it never
>> actually got applied.  Perhaps using search on the subject line of it
>> will give you some more background on the somewhat inconclusive
>> response to the proposal.
> For your convenience, the thread is at
>
> 	http://thread.gmane.org/gmane.comp.version-control.git/55667/match=angle+brackets+reply+to
>
> Is there anyone who saw message-id's not having the form 
>
> 	"<" addr-spec ">"
>
> ?

message-id's are defined to have the angle brackets.

    message-id      =       "Message-ID:" msg-id CRLF
    in-reply-to     =       "In-Reply-To:" 1*msg-id CRLF
    references      =       "References:" 1*msg-id CRLF
    msg-id          =       [CFWS] "<" id-left "@" id-right ">" [CFWS]

The patch and my comment on "git-format-patch --in-reply-to" are
merely about being user friendly.  We _could_ require the id
given by the user to have angle brackets.  But we do not have
to, because we can add them ourselves when the given string is
not enclosed by them.

The real question, if you want to play an RFC lawyer, is, if
id-left can begin or id-right can end with angle brackets (I do
not think so).  And another practical question is if it matters
if we drop the beginning/ending angle brackets in them if they
do (I do not think so either).
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux