On Mon, Oct 04, 2021 at 03:42:48AM +0200, Ævar Arnfjörð Bjarmason wrote: > Change tests added in 1ffa26c4614 (get_short_sha1: list ambiguous > objects on error, 2016-09-26) to only care about the OIDs that are > listed, which is what the test is trying to check for. > > This isn't needed by the subsequent commit, which won't change any of > the output, but a mere tightening of the tests assertions to more > closely match what we really want to test for here. I think the next commit does change the output. It adds an extra empty line which would cause these tests to fail. > Now if the advise() message itself were change the phrasing around the > list of OIDs we won't have this test break. We're assuming that such > output won't have a need to indent anything except the OIDs. It feels like we're trading one assumption for another. :) I admit that don't care much either way, though. -Peff
