A follow-up to recent advice.[ch] improvements in fd0d7036e0d (Merge branch 'ab/retire-advice-config', 2021-09-10). There are no in-flight additions of new advice variables, and this doesn't conflict with "seen". So now seems like a good time to submit this. The API carried some complexity due to needing to alias one of the variables, which goes away in 3/5, 4/5 then further reduces boilerplate. Ævar Arnfjörð Bjarmason (5): advice.h: don't indent top-level enum advice output: emit empty lines as "hint:", not "hint: " advice.[ch]: remove advice.pushNonFastForward alias advice API: revamp the API, again advice.[ch]: sort enum fields in alphabetical order advice.c | 100 +++++++++----------- advice.h | 5 +- contrib/mw-to-git/git-remote-mediawiki.perl | 2 +- t/t7004-tag.sh | 4 +- 4 files changed, 51 insertions(+), 60 deletions(-) -- 2.33.0.1404.g7bcfc82b295