Re: [PATCH] git-send-email.perl: Add angle brackets to In-Reply-To if necessary

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 12, 2007 at 05:53:45AM +0000, David Kastrup wrote:
> 
> Signed-off-by: David Kastrup <dak@xxxxxxx>
> ---
> I had previously already sent this patch.  It is somewhat more robust
> than your version against off-by-one cut&paste errors.  But it never
> actually got applied.  Perhaps using search on the subject line of it
> will give you some more background on the somewhat inconclusive
> response to the proposal.
> 
> If I remember correctly, git-am-patch takes exactly the other polarity
> than the old git-send-email with regard to adding angle brackets about
> message ids from the command line, so defusing that command as well
> would probably be appreciated by some.
> 
>  git-send-email.perl |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 69559b2..877f74c 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -309,7 +309,8 @@ if ($thread && !defined $initial_reply_to && $prompting) {
>  	} while (!defined $_);
>  
>  	$initial_reply_to = $_;
> -	$initial_reply_to =~ s/(^\s+|\s+$)//g;
> +	$initial_reply_to =~ s/^\s+<?/</;
> +	$initial_reply_to =~ s/>?\s+$/>/;
>  }

  Right it indeed makes more sense, and the style sucks less than my
perl skills :) Or my lack of for that matter.

-- 
·O·  Pierre Habouzit
··O                                                madcoder@xxxxxxxxxx
OOO                                                http://www.madism.org

Attachment: pgpCJIer2iI1i.pgp
Description: PGP signature


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux