Re: [PATCH 3/6] Rework pretty_print_commit to use strbufs instead of custom buffers.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Pierre Habouzit <madcoder@xxxxxxxxxx> writes:

> +void pretty_print_commit(enum cmit_fmt fmt, const struct commit *commit,
> +				  struct strbuf *sb, int abbrev,
> +				  const char *subject, const char *after_subject,
>  				  enum date_mode dmode)
>  {
> -	unsigned long offset = 0;
>  	unsigned long beginning_of_body;
>  	int indent = 4;
>  	const char *msg = commit->buffer;
>  	int plain_non_ascii = 0;
>  	char *reencoded;
>  	const char *encoding;
> -	char *buf;
>  
>  	if (fmt == CMIT_FMT_USERFORMAT)
> -		return format_commit_message(commit, user_format, buf_p, space_p);
> +		return format_commit_message(commit, user_format, sb);
>  
>  	encoding = (git_log_output_encoding
>  		    ? git_log_output_encoding

No way this can be correct.

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux