>From Nicolas Pitre <nico@xxxxxxx> > 1) pushes happen less often than fetches, so the bandwidth saving is > much less visible in that case overall. > > 2) thin packs have to be complemented with missing delta bases to be > valid, so many received thin packs will take more disk space. > > 3) the bother of repacking should be distributed amongst "clients" > i.e. fetchers and pushers as much as possible, and not the server > being fetched or pushed, to keep disk and CPU usage low on the > server. > > This is why a fetch should get thin packs but a push should not. Both Nico and I have been assuming that --no-thin was the default behavior of git-push ever since Nico introduced --fix-thin into the index-pack process, which allowed fetch and receive-pack to avoid exploding packfiles received during transfer. This patch finally makes it so. Signed-off-by: Shawn O. Pearce <spearce@xxxxxxxxxxx> --- builtin-push.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/builtin-push.c b/builtin-push.c index 2612f07..88c5024 100644 --- a/builtin-push.c +++ b/builtin-push.c @@ -9,7 +9,7 @@ static const char push_usage[] = "git-push [--all] [--tags] [--receive-pack=<git-receive-pack>] [--repo=all] [-f | --force] [-v] [<repository> <refspec>...]"; -static int all, force, thin = 1, verbose; +static int all, force, thin, verbose; static const char *receivepack; static const char **refspec; -- 1.5.3.1.880.g5a3ab - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
