On Wed, Sep 08, 2021 at 12:24:09PM -0400, Taylor Blau wrote: > On Wed, Sep 08, 2021 at 08:38:55AM -0700, Junio C Hamano wrote: > > * tb/pack-finalize-ordering (2021-09-07) 2 commits > > - builtin/repack.c: move `.idx` files into place last > > - pack-write.c: rename `.idx` file into place last > > > > The order in which various files that make up a single (conceptual) > > packfile has been reevaluated and straightened up. This matters in > > correctness, as an incomplete set of files must not be shown to a > > running Git. > > > > Will merge to 'next'? > > Ævar has a series [1] that complements this one nicely, so I would be > happy to see them both queued. > > I had some suggestions inline, but I don't feel strongly about whether > or not they are implemented. I think regardless of Ævar's related patches, we'd want to see a re-roll of yours that touches index-pack's final(), too. -Peff