Simon Sasburg <simon.sasburg@xxxxxxxxx> wrote: > This patch fixes selection of fonts under X11 by using combobox widget > instead of tk_optionmenu widget > > The tk_optionmenu widget previously used has a bug in X11 that > prevents you from scrolling it, and thus prevents you from selecting > fonts beyond those that fit on the screen. > We work around this by using a 3rd party combobox widget that does > allow scrolling. > > I'm not too sure this is the right solution (using 3rd party widget), > but it does work, and it does solve the problem. > > The combobox widget comes from here: > http://www1.clearlight.com/~oakley/tcl/combobox/index.html I played around with this and half like the approach used. The widget does seem like it would resolve the scrolling bug you talk about on X11 but it has some serious focus issues on Mac OS X. For example once you pop up the combox box list if you try to click elsewhere in the parent widget the list has grabbed the UI and won't let you do so. Pressing Esc doesn't clear the list away either; the only action that will do so is to select an entry in the list. A few times I did manage to make the parent window raise up over the popup list, while the list was still displayed. This makes for a very confusing display. I know X11 has a really crappy display for Tk but on Windows and Mac OS X the tk_optionMenu that comes with Tk on those systems is mapped to native OS controls, making git-gui fit into the overall desktop environment better on those platforms. Using this widget takes that away. I'm actually thinking about creating a font choosing widget that we can open into a new toplevel dialog and let the user select the family from a scrolling box, and the size, and then see some example texts drawn in that configuration. It isn't the native font chooser for the platform (e.g. Mac OS X) but it would be a better UI for font selection than this combox box based approach. -- Shawn. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
