Re: [RFC PATCH] send-email: allow fixing the cover letter subject

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 24, 2021 at 11:31 PM Marvin Häuser <mhaeuser@xxxxxxxxx> wrote:
> On 24/08/2021 18:11, Carlo Arenas wrote:
> > On Tue, Aug 24, 2021 at 8:19 AM Marvin Häuser <mhaeuser@xxxxxxxxx> wrote:
> >> On 24/08/2021 13:41, Carlo Marcelo Arenas Belón wrote:
> >>> @@ -1719,7 +1719,6 @@ sub process_file {
> >>>        @xh = ();
> >>>        my $input_format = undef;
> >>>        my @header = ();
> >>> -     $subject = $initial_subject;
> Can we somehow agree on something? Because I'd like to submit my patch asap.

I think you are correct, and from a flow point of view it should be
reset there with the rest.
Adding something to the commit message to explain it might help, and
the documentation path
I suggested (or something better) might be worth squashing to better
explain why the last test case that resets in-reply-to headers is
correct.

Carlo




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux