Re: [PATCH] Revert 'diff-merges: let "-m" imply "-p"'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster@xxxxxxxxx> writes:

> Jonathan Nieder <jrnieder@xxxxxxxxx> writes:
>
>> Junio C Hamano wrote:
>>
>>> For example, 1e20a407 (stash list: stop passing "-m" to "git log",
>>> 2021-05-21) that dropped "-m" must be reverted as well, no?
>>
>> No, that change is fine.  The "-m" doesn't have an effect one way or
>> another after this revert.
>
> Ah, we are saved by the fact that "--first-parent" was made to imply
> "-m", so a "-p" coming from the command line of "git stash list"
> would do "log --first-parent -p" that shows the patch we want
> without the need for "-m"... nice.

So, do I get it right that there is actually no reason to use "log
--first-parent -m" anymore, since the time the much older commit made
--first-parent imply -m?

If so, I'd object against this particular patch as the pros of patch
being reverted outweighs its cons, and the original patch never meant to
be entirely backward compatible in the first place, when it was
accepted.

Thanks,
-- Sergey Organov



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux