On Tue, Aug 03, 2021 at 00:09:25 +0200, Johannes Schindelin wrote: > On Fri, 30 Jul 2021, Ben Boeckel wrote: > > All of the preferences are now tracked as part of the `advice_setting` > > array and all consumers of the global variables have been removed, so > > the parallel tracking through `advice_config` is no longer necessary. > > Maybe add "This concludes the move from the old advice API to the new one > introduced via c4a09cc9ccb (Merge branch 'hw/advise-ng', 2020-03-25)"? > > At least this reader would have found that helpful. Agreed. > And as I mentioned in the review of patch 3/4, the removal of the > explicit assignment to the `advice_*` global variables should be moved > here. I addressed this in the 3/4 thread. Thanks, --Ben
