Hi, When looking at global variable usage for my `branch.default*` settings, I found the `advice_` variables which were simple enough to resolve. --Ben --- Ben Boeckel (4): advice: add a function to set the value of an advice type advice: add enum variants for missing advice variables advice: remove uses of global `advice_` variables advice: remove static global variables for advice tracking advice.c | 88 ++++--------------------------------- advice.h | 38 +++------------- branch.c | 2 +- builtin/add.c | 8 ++-- builtin/am.c | 2 +- builtin/checkout.c | 6 +-- builtin/clone.c | 2 +- builtin/commit.c | 4 +- builtin/fetch.c | 2 +- builtin/merge.c | 4 +- builtin/push.c | 12 ++--- builtin/replace.c | 2 +- builtin/reset.c | 2 +- builtin/rm.c | 2 +- builtin/submodule--helper.c | 2 +- commit.c | 2 +- editor.c | 2 +- notes-merge.c | 2 +- object-name.c | 2 +- remote.c | 12 ++--- run-command.c | 2 +- sequencer.c | 8 ++-- unpack-trees.c | 18 ++++---- wt-status.c | 6 +-- 24 files changed, 68 insertions(+), 162 deletions(-) base-commit: eb27b338a3e71c7c4079fbac8aeae3f8fbb5c687 -- 2.31.1