On Thu, Jul 15, 2021 at 1:17 PM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > On Wed, Jul 14, 2021 at 10:32 PM Stephen Manz via GitGitGadget > <gitgitgadget@xxxxxxxxx> wrote: > > Changes since v3: > > > > * Updated test to define a shell variable, lock_reason, set to "why not". > > Expand the variable to use with --reason and to echo to file, expected. > > This avoids the spacing comment made by Eric Sunshine. > > Thanks, these changes look fine to me. I don't know whether or not > Junio has merged this series down to his "next" branch yet locally, > though. If he has, then he may not pick up your v4, and this minor > cleanup change could instead be done as a standalone patch atop v3 (or > could be dropped since v3 was probably "good enough"). It looks like Junio did pick up v4, so no need for a standalone cleanup patch atop v3.
