Re: [RFC] Convert builin-mailinfo.c to use The Better String Library.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Lukas Sandström, Tue, Sep 04, 2007 22:50:08 +0200:
> Hi.
> 
> This is an attempt to use "The Better String Library"[1] in builtin-mailinfo.c
> 
> The patch doesn't pass all the tests in the testsuit yet, but I thought I'd
> send it out so people can decide if they like how the code looks.

It looks uglier, but what are measurable merits? Object code size,
perfomance hit/improvement, valgrind logs?

> -static int read_one_header_line(char *line, int sz, FILE *in)
> +static int read_one_header_line(struct bStream *in, bstring line)

Every coder has a time in his life when he writes a string library...
and a stream support for it.

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux