Johannes Sixt <j.sixt@xxxxxxxxxxxxx> writes: > Marius Storm-Olsen schrieb: > >> Ok, I can give it a performance test, but I tend to agree with >> David Kastrup there. It would be better if we rather fix the places >> where we check with the local timestamp instead; depending of >> course on how many places we actually do this. We'll see how much >> the timezone conversion in the custom stat functions actually hurt >> us performance wise. > > I'd make the decision on the grounds of a perfomance test. If it > turns out that the penalty is bearable, we should keep this stuff > private to the MinGW build. Otherwise, we would need MinGW specific > code at the call sites (unless we can hide the opposite conversion > in some other wrapper function). > > ... time passes ... > > Ok, I just tested FileTimeToLocalFileTime() in a tight loop, and I > can run it 100,000,000 times per second. So I'm confident that there > won't be any noticable degradation with my proposed change. The problem is that it will break in the hour when day light saving time ends. Or when you travel between timezones. Local time is not continuous or unique. That is why it is a bad idea to make decisions based on it. -- David Kastrup, Kriemhildstr. 15, 44793 Bochum - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
