On July 2, 2021 5:02 PM, Felipe Contreras wrote: >To: Randall S. Becker <rsbecker@xxxxxxxxxxxxx>; 'martin' <test2@xxxxxxxxxx>; 'Felipe Contreras' <felipe.contreras@xxxxxxxxx>; >'Andreas Schwab' <schwab@xxxxxxxxxxxxxx> >Cc: git@xxxxxxxxxxxxxxx; 'Ævar Arnfjörð Bjarmason' <avarab@xxxxxxxxx>; 'Junio C Hamano' <gitster@xxxxxxxxx> >Subject: RE: [PATCH 5/5] config: add default aliases > >Randall S. Becker wrote: > >> In my opinion, default aliases are not a good path. If a command is >> intended to be part of the git command set, then it should be a >> builtin not an alias. > >Commands cannot be overriden, aliases can. > >All SCM projects have aliases, except git. Why do you think that is? I do not think my intent was conveyed. Default aliases made by the product provider, regardless of who that is, are not a good path. If I was RCS, I would not make an alias that everyone had to take. Same for git. git has aliases, but they are for the user. If the end-user team wants to implement a particular set of primitives for their environment, that's fantastic, and entirely possible in git. But I do not want to be constrained by someone else's primitives that are not core product. >> Users have their own alias setups and implied conflicts are just going >> to be confusing and end up in help, examples, presentations, and so >> forth. > >There's no conflict. Either you use the alias or you don't. Just like today. Then what is the point of this? I want my aliases, not someone else's. Again, if it is a core git alias, it is not an alias, it is a supported command and I should see it in the git help -a output. >> If you want a default alias set, publish it as part of an extension >> set, like the bash-completion, so that the user has to take action to >> install them in their environment. Do not do this in the base git >> product by default. > >The whole point is to help users so they don't have to do extra configurations. The whole point is that a user team should give thought to the functional extensions they want, as a team, which is where aliases come in. We, as git contributors, should not be telling them what their extensions are. >Today git is pretty much unbearable without a configuration. Default aliases would help quell some of that pain. Git is entirely bearable particularly in my own pons and medulla. I have three bash aliases, two for log, one for removing tags and no git aliases and I am highly productive. Would that make ECLIPSE intolerable? >> If I was a committer on this project, I would have to be much more >> convinced that there is long-term value in this series than appears on >> the surface. > > 1. It doesn't affect anyone negatively > 2. You don't have to use them if you don't want to 3. They don't affect your aliases, even if they have the same name 4. Everyone has >aliases 5. Every SCM in history has had aliases > >What more would you need? > >> I am sorry if I am coming across too strongly on this subject, but I >> do think we are overloading alias capability and intruding on a domain >> that should be reserved for our users, not ourselves. > >But why? We provide plenty of defaults so that users don't have to configure git in order for the program to be useful. And we will >continue to add more defaults. I remain unconvinced and I found the assertion #5 somewhat specious and incorrect. SCCS and RCS use Shell aliases. There are no aliases in ClearCase. Granted Perforce has them, but that is not a sufficient differentiator to use that over git by any stretch. Why are we trying to create a standard set of aliases? I do not like the RCS primitives - never did - as a base and would not use them. If the command set is not sufficient, then it should be extended. If it is sufficient but complex for some, *they* can create aliases. I come back to my point that a community-based set of alias extensions should be managed as a distinct Open Source product that can be cloned from some cloud service and maintained independently from git. There is nothing stopping that from happening, except perhaps for something like an include operation in .gitconfig, which I think would be either a really good idea, or subject to a CVE, or both. I've expressed my opinion, and it's not my decision to adopt this. So whatever happens, as long as it does not pollute my community's expectation of git. Although, providing aliases will handcuff future command naming.
