Re: [PATCH 14/15] [GSOC] cat-file: re-implement --textconv, --filters options

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"ZheNing Hu via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:

> From: ZheNing Hu <adlternative@xxxxxxxxx>
>
> After cat-file reuses the ref-filter logic, we re-implement the
> functions of --textconv and --filters options.
>
> Add members `use_textconv` and `use_filters` in struct `ref_format`,
> and use global variables `use_filters` and `use_textconv` in
> `ref-filter.c`, so that we can filter the content of the object
> in get_object().

These global variables are problematic.  The places that check them
are quite isolated, and it makes me wonder why we cannot pass a
format instance through the callchain down to get_object().

 



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux