"ZheNing Hu via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > +#define USE_THE_INDEX_COMPATIBILITY_MACROS > #include "builtin.h" > #include "cache.h" > #include "parse-options.h" > @@ -84,6 +85,9 @@ static struct expand_data { > struct object_info info; > } oi, oi_deref; > > +int use_filters; > +int use_textconv; With this commit in, "make sparse" dies like so: SP ref-filter.c ref-filter.c:88:5: error: symbol 'use_filters' was not declared. Should it be static? ref-filter.c:89:5: error: symbol 'use_textconv' was not declared. Should it be static?