This series implements a suggestion by Jeff King to use an idiom for *_init() functions that avoids duplicating what we've declared in the corresponding *_INIT macros. See https://lore.kernel.org/git/YNytp0JAIaQih0Y4@xxxxxxxxxxxxxxxxxxxxxxx/ Ævar Arnfjörð Bjarmason (5): *.h: move some *_INIT to designated initializers *.c *_init(): define in terms of corresponding *_INIT macro dir.[ch]: replace dir_init() with DIR_INIT string-list.[ch]: add a string_list_init_{nodup,dup}() string-list.h users: change to use *_{nodup,dup}() apply.c | 6 +++--- archive.c | 2 +- builtin/add.c | 3 +-- builtin/check-ignore.c | 3 +-- builtin/clean.c | 6 ++---- builtin/grep.c | 3 +-- builtin/ls-files.c | 3 +-- builtin/stash.c | 3 +-- config.c | 2 +- credential.c | 4 ++-- credential.h | 4 +++- dir.c | 9 ++------- dir.h | 4 ++-- entry.c | 4 ++-- json-writer.c | 6 ++---- json-writer.h | 5 ++++- merge-ort.c | 4 ++-- merge-recursive.c | 4 ++-- merge.c | 3 +-- refs/packed-backend.c | 2 +- run-command.c | 5 ++--- run-command.h | 5 ++++- strbuf.c | 4 ++-- string-list.c | 18 ++++++++++++++++-- string-list.h | 15 +++++++++++---- strmap.c | 3 ++- strvec.c | 5 ++--- transport.c | 2 +- wt-status.c | 3 +-- 29 files changed, 76 insertions(+), 64 deletions(-) -- 2.32.0.623.ge833f40cd87
