On Tue, Jun 15 2021, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > >> This refactors the testing of test-lib.sh itself in t0000 into a >> lib-subtest.sh, fixing duplicate setup, bugs and various shell nits >> along the way. >> ... >> I thought it was better to submit this now anyway, while >> this code is fresh in people's minds. > > Any time you send it anew is the time it is fresh in people's minds > if they read it, no? I am not sure I understand the reasoning. > >> I'm hoping Felipe will take some variant of my >> http://lore.kernel.org/git/8735tk22if.fsf@xxxxxxxxxxxxxxxxxxx and >> perhaps review this series & base his patch on top of these changes, >> but alternatively they can go in independently with Junio solving the >> conflict. > > I'd rather not if it can be avoided. Please scale the process by > coordinating among contributors yourselves. Per Felipe's reply and his https://lore.kernel.org/git/20210615183157.104999-1-felipe.contreras@xxxxxxxxx/ I don't think there's any conflict anymore, so this series should apply on master without any conflicts. It would be great to have it picked up, it's another set of test cleanups I need for a subsequent series...